Skip to content

[CONFIGURATION] File configuration - metric model#3474

Merged
marcalff merged 7 commits intomainfrom
merge_config_metric_model
Jun 28, 2025
Merged

[CONFIGURATION] File configuration - metric model#3474
marcalff merged 7 commits intomainfrom
merge_config_metric_model

Conversation

@marcalff
Copy link
Copy Markdown
Member

@marcalff marcalff commented Jun 12, 2025

Contributes to #2481

This is a partial fix, that implements supporting declarations.

Changes

Please provide a brief description of the changes here.

  • Implement the metric model for file configuration.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 12, 2025
@marcalff marcalff marked this pull request as ready for review June 12, 2025 19:26
@marcalff marcalff requested a review from a team as a code owner June 12, 2025 19:26
@marcalff marcalff mentioned this pull request Jun 12, 2025
Closed
62 tasks
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 12, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 9530da4
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6860633303ae7400087b65d3

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (85b0ada) to head (9530da4).
⚠️ Report is 295 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3474      +/-   ##
==========================================
- Coverage   89.96%   89.95%   -0.01%     
==========================================
  Files         219      219              
  Lines        7051     7051              
==========================================
- Hits         6343     6342       -1     
- Misses        708      709       +1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

marcalff
marcalff commented Jun 25, 2025
View reviewed changes
Comment thread sdk/include/opentelemetry/sdk/configuration/otlp_file_push_metric_exporter_configuration.h Outdated
dbarker
dbarker reviewed Jun 25, 2025
View reviewed changes
Comment thread sdk/include/opentelemetry/sdk/configuration/metric_reader_configuration.h Outdated
dbarker
dbarker reviewed Jun 25, 2025
View reviewed changes
Comment thread sdk/include/opentelemetry/sdk/configuration/otlp_grpc_push_metric_exporter_configuration.h Outdated
dbarker
dbarker reviewed Jun 25, 2025
View reviewed changes
Comment thread sdk/include/opentelemetry/sdk/configuration/otlp_http_push_metric_exporter_configuration.h Outdated
dbarker
dbarker approved these changes Jun 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff merged commit f16ea3b into main Jun 28, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_metric_model branch June 28, 2025 23:09
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@dbarker dbarker dbarker approved these changes

Assignees

No one assigned

Labels

pr:please-review This PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcalff @ThomsonTan @dbarker